Skip to content

chore(typescript): Enable strictNullChecks for the SDK source #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Apr 16, 2025

These are enabled in JS Core since the last major v8.

Let's enable them in RN as well.

This PR should not introduce any behavior changes, only fix the null checks.

#skip-changelog

@krystofwoldrich krystofwoldrich marked this pull request as draft April 16, 2025 18:00
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 395.40 ms 392.28 ms -3.11 ms
Size 17.75 MiB 19.54 MiB 1.80 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9da5c4e 478.08 ms 467.46 ms -10.63 ms
9fbcfaf 420.06 ms 435.31 ms 15.25 ms

App size

Revision Plain With Sentry Diff
9da5c4e 17.75 MiB 20.16 MiB 2.41 MiB
9fbcfaf 17.75 MiB 19.54 MiB 1.79 MiB

Previous results on branch: kw-fix-null-checks

Startup times

Revision Plain With Sentry Diff
0c30894 419.04 ms 423.62 ms 4.58 ms

App size

Revision Plain With Sentry Diff
0c30894 17.75 MiB 19.54 MiB 1.79 MiB

Copy link
Contributor

github-actions bot commented Apr 16, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 420.51 ms 432.88 ms 12.37 ms
Size 7.15 MiB 8.30 MiB 1.14 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 417.92 ms 431.81 ms 13.90 ms
9da5c4e+dirty 399.70 ms 407.34 ms 7.64 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 7.15 MiB 8.29 MiB 1.14 MiB
9da5c4e+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Previous results on branch: kw-fix-null-checks

Startup times

Revision Plain With Sentry Diff
0c30894+dirty 398.92 ms 403.75 ms 4.83 ms

App size

Revision Plain With Sentry Diff
0c30894+dirty 7.15 MiB 8.29 MiB 1.14 MiB

Copy link
Contributor

github-actions bot commented Apr 16, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.47 ms 1219.53 ms 4.06 ms
Size 3.19 MiB 4.34 MiB 1.15 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 1215.22 ms 1222.26 ms 7.04 ms
9da5c4e+dirty 1215.41 ms 1226.38 ms 10.97 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 3.19 MiB 4.34 MiB 1.15 MiB
9da5c4e+dirty 3.19 MiB 4.33 MiB 1.14 MiB

Previous results on branch: kw-fix-null-checks

Startup times

Revision Plain With Sentry Diff
0c30894+dirty 1217.24 ms 1216.37 ms -0.88 ms

App size

Revision Plain With Sentry Diff
0c30894+dirty 3.19 MiB 4.34 MiB 1.15 MiB

Copy link
Contributor

github-actions bot commented Apr 16, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.10 ms 1225.61 ms 10.51 ms
Size 2.63 MiB 3.77 MiB 1.14 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 1216.66 ms 1212.06 ms -4.60 ms
9da5c4e+dirty 1231.84 ms 1235.49 ms 3.65 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 2.63 MiB 3.77 MiB 1.14 MiB
9da5c4e+dirty 2.63 MiB 3.76 MiB 1.13 MiB

Previous results on branch: kw-fix-null-checks

Startup times

Revision Plain With Sentry Diff
0c30894+dirty 1223.60 ms 1236.98 ms 13.38 ms

App size

Revision Plain With Sentry Diff
0c30894+dirty 2.63 MiB 3.77 MiB 1.14 MiB

@krystofwoldrich krystofwoldrich changed the title typescript: Enable strictNullChecks chore(typescript): Enable strictNullChecks for the SDK source Apr 28, 2025
@krystofwoldrich krystofwoldrich marked this pull request as ready for review April 28, 2025 16:04
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for enabling strictNullChecks and improving the code along the way 🎸

@krystofwoldrich krystofwoldrich merged commit 391dc92 into v7 Apr 29, 2025
74 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-fix-null-checks branch April 29, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants